This repository was archived by the owner on Jun 4, 2018. It is now read-only.
Open
Conversation
Owner
|
This is definitely a good solution for the time being. Nice job! 👍 I still plan on doing a rewrite in the future with Icicle, but it may be some time yet before the Icicle websocket package is ready. |
mcrumm
force-pushed
the
feature/use_pawl
branch
from
c47d040 to
95b1841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #14.
This PR replaces
devristo/phpwswithratchet/pawl, a WebSocket client that's more closely aligned with the rest of the ReactPHP ecosystem.PHP7 is already supported, though some older versions have bugs. This is due to a workaround in
react/socket-clientfor handling encrypted streams. I'll save you the trip down the rabbit hole: Some versions work, some don't, and the problem is the openssl extension. Depending on your PHP version, you might need to pinreact/socket-clientto a specific release if things aren't working quite right.PS: I added the
examplebotand the robo task primarily for testing. If you're interested in merging this, but would rather not include those changes, I would be happy to remove them.